Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7179#discussion_r33749834
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -42,4 +47,47 @@ class CodeGenerationSuite extends SparkFunSuite {
futures.foreach(Await.result(_, 10.seconds))
}
+
+ // Test GenerateOrdering for all common types. For each type, we
construct random input rows that
+ // contain two columns of that type, then for pairs of
randomly-generated rows we check that
+ // GenerateOrdering agrees with RowOrdering.
+ (DataTypeTestUtils.atomicTypes ++ Set(NullType)).foreach { dataType =>
--- End diff --
This test is total overkill, but it's a neat example of how randomized data
generation plus a list of types can be used for exploratory testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
