Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33792212
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -206,8 +228,7 @@ private[spark] class CoarseMesosSchedulerBackend(
Collections.singleton(offer.getId),
Collections.singletonList(task.build()), filters)
} else {
// Filter it out
- d.launchTasks(
- Collections.singleton(offer.getId),
Collections.emptyList[MesosTaskInfo](), filters)
+ d.declineOffer(offer.getId)
--- End diff --
It's the same thing, just clearer in its intentions. According to Javadocs
on
[SchedulerDriver](http://mesos.apache.org/api/latest/java/org/apache/mesos/SchedulerDriver.html#launchTasks(java.util.Collection,%20java.util.Collection,%20Filters)):
> .. Invoking this function with an empty collection of tasks declines
offers in their entirety (see declineOffer(OfferID, Filters)).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
