Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4984#discussion_r33723361
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -124,10 +124,16 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
(blockId, getFile(blockId))
}
+ /**
+ * Create local directories for storing block data. These directories are
+ * located inside configured local directories and won't
+ * be deleted on JVM exit when using the external shuffle service.
--- End diff --
I just read it again. You mentioned that "on Mesos the shuffle dir is not
deleted, but its parent directory is". I'm confused about two things: First, if
the parent directory is deleted, wouldn't everything it automatically be
deleted as well?
Second, I actually don't see how the parent directory (the middle layer in
your comment) is deleted. Are you referring to `DiskBlockManager#doStop()`?
AFAIK that only deletes the temporary directory created inside of the parent
directory (i.e. the shuffle dir), and we don't do this if external shuffle
service. I can't find the code that deletes the middle layer itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
