Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/899#discussion_r13121927
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -473,15 +474,15 @@ object ClientBase {
if (localPath != null) {
val parentPath = new File(localPath).getParent()
YarnSparkHadoopUtil.addToEnvironment(env,
Environment.CLASSPATH.name, parentPath,
- File.pathSeparator)
+ ApplicationConstants.CLASS_PATH_SEPARATOR)
--- End diff --
As you say, this value only appeared in Hadoop 2.4.0:
http://hadoop.apache.org/docs/r2.4.0/api/org/apache/hadoop/yarn/api/ApplicationConstants.html
http://hadoop.apache.org/docs/r2.3.0/api/org/apache/hadoop/yarn/api/ApplicationConstants.html
File.pathSeparator should already be ":" vs ";", which is what you intend
right?
http://docs.oracle.com/javase/7/docs/api/java/io/File.html#pathSeparator
I'm missing what this changes then. I understand that the char may vary on
the client vs cluster, and that's why it's right to reference a symbolic
constant, but these seem to be the same in that respect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
