Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7157#discussion_r33987826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -426,10 +424,7 @@ case class Cast(child: Expression, dataType: DataType)
extends UnaryExpression w
private[this] lazy val cast: Any => Any = cast(child.dataType, dataType)
- override def eval(input: InternalRow): Any = {
- val evaluated = child.eval(input)
- if (evaluated == null) null else cast(evaluated)
- }
+ protected override def nullSafeEval(evalE: Any): Any = cast(evalE)
--- End diff --
it's weird to name this "eval". How about just input?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
