Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7157#discussion_r33988758
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -50,22 +49,12 @@ trait StringRegexExpression extends ExpectsInputTypes {
protected def pattern(str: String) = if (cache == null) compile(str)
else cache
- override def eval(input: InternalRow): Any = {
- val l = left.eval(input)
- if (l == null) {
+ protected override def nullSafeEval(l: Any, r: Any): Any = {
--- End diff --
input1, input2 might be better here actually since binary expressions
already define left/right and we risk shadowing them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
