Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/7243#issuecomment-119364467
  
    > Hmm, I think I will punt on fixing the client and defend against NPE's 
with null checks
    
    The thing is, if you use the endpoint route, the same code would work for 
both client and cluster. You don't need to special case anything. You'd just 
send a message to the driver saying "removeExecutor" and the driver would 
handle it, regardless of where it is. No plumbing of the "backend" variable 
anywhere.
    
    Your current code is explicitly coupled to cluster mode and cannot, ever, 
work in client mode. So fixing this for client mode would mean reverting your 
changes. So why not do the final change right now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to