Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7291#discussion_r34158183
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
    @@ -53,70 +53,8 @@ abstract class InternalRow extends Row {
     
       // A default implementation to change the return type
       override def copy(): InternalRow = this
    -  override def apply(i: Int): Any = get(i)
    --- End diff --
    
    The origin code is weird. We have defined `get(i: Int) = apply(i)`, and we 
should implement `apply` in subclasses. However, we change this definition here 
and subclasses of `InternalRow` have to implement `get`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to