Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7291#discussion_r34162585
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
    @@ -363,6 +363,69 @@ trait Row extends Serializable {
         false
       }
     
    +  protected def canEqual(other: Any) = other.isInstanceOf[Row]
    --- End diff --
    
    `other` could be `null`. And `=(other.getClass == this.getClass)`, so we 
don't need to override it within its subclasses.
    BTW: Should we mark it identical for a GenericRow and a MutableRow if they 
contains exactly the same elements?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to