[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

Wed, 08 Jul 2015 18:04:16 -0700 

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6762#discussion_r34215417
  
    --- Diff: 
unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java ---
    @@ -121,11 +121,86 @@ public void endsWith() {
     
       @Test
       public void substring() {
    -    assertEquals(fromString("hello").substring(0, 0), fromString(""));
    -    assertEquals(fromString("hello").substring(1, 3), fromString("el"));
    -    assertEquals(fromString("数据砖头").substring(0, 1), 
fromString("数"));
    -    assertEquals(fromString("数据砖头").substring(1, 3), 
fromString("据砖"));
    -    assertEquals(fromString("数据砖头").substring(3, 5), 
fromString("头"));
    -    assertEquals(fromString("ߵ梷").substring(0, 2), fromString("ߵ梷"));
    +    assertEquals(fromString(""), fromString("hello").substring(0, 0));
    +    assertEquals(fromString("el"), fromString("hello").substring(1, 3));
    +    assertEquals(fromString("数"), fromString("数据ç 
–头").substring(0, 1));
    +    assertEquals(fromString("据砖"), fromString("数据ç 
–头").substring(1, 3));
    +    assertEquals(fromString("头"), fromString("数据ç 
–头").substring(3, 5));
    +    assertEquals(fromString("ߵ梷"), fromString("ߵ梷").substring(0, 2));
    +  }
    +
    +  @Test
    +  public void trims() {
    +    assertEquals(fromString("hello"), fromString("  hello ").trim());
    +    assertEquals(fromString("hello "), fromString("  hello ").trimLeft());
    +    assertEquals(fromString("  hello"), fromString("  hello 
").trimRight());
    +
    +    assertEquals(fromString(""), fromString("  ").trim());
    +    assertEquals(fromString(""), fromString("  ").trimLeft());
    +    assertEquals(fromString(""), fromString("  ").trimRight());
    +
    +    assertEquals(fromString("数据砖头"), fromString("  数据砖头 
").trim());
    +    assertEquals(fromString("数据砖头 "), fromString("  数据砖头 
").trimLeft());
    +    assertEquals(fromString("  数据砖头"), fromString("  数据砖头 
").trimRight());
    +
    +    assertEquals(fromString("数据砖头"), fromString("数据ç 
–头").trim());
    +    assertEquals(fromString("数据砖头"), fromString("数据ç 
–头").trimLeft());
    +    assertEquals(fromString("数据砖头"), fromString("数据ç 
–头").trimRight());
    +  }
    +
    +  @Test
    +  public void instr() {
    +    assertEquals(0, fromString("").instr(fromString(""), 0));
    +    assertEquals(-1, fromString("").instr(fromString("l"), 0));
    +    assertEquals(0, fromString("hello").instr(fromString(""), 0));
    +    assertEquals(2, fromString("hello").instr(fromString("l"), 0));
    +    assertEquals(3, fromString("hello").instr(fromString("l"), 3));
    +    assertEquals(-1, fromString("hello").instr(fromString("a"), 0));
    +    assertEquals(2, fromString("hello").instr(fromString("ll"), 0));
    +    assertEquals(-1, fromString("hello").instr(fromString("ll"), 4));
    +    assertEquals(1, fromString("数据砖头").instr(fromString("据砖"), 
0));
    +    assertEquals(-1, fromString("数据砖头").instr(fromString("数"), 
3));
    +    assertEquals(0, fromString("数据砖头").instr(fromString("数"), 
0));
    +    assertEquals(3, fromString("数据砖头").instr(fromString("头"), 
0));
    +  }
    +
    +  @Test
    +  public void reverse() {
    +    assertEquals(fromString("olleh"), fromString("hello").reverse());
    +    assertEquals(fromString(""), fromString("").reverse());
    +    assertEquals(fromString("者行孙"), fromString("孙行者
").reverse());
    +    assertEquals(fromString("者行孙 olleh"), fromString("hello 孙行者
").reverse());
    +  }
    +
    +  @Test
    +  public void pad() {
    +    assertEquals(fromString("hel"), fromString("hello").lpad(3, 
fromString("????")));
    +    assertEquals(fromString("hello"), fromString("hello").lpad(5, 
fromString("????")));
    +    assertEquals(fromString("?hello"), fromString("hello").lpad(6, 
fromString("????")));
    +    assertEquals(fromString("???????hello"), fromString("hello").lpad(12, 
fromString("????")));
    +    assertEquals(fromString("?????hello"), fromString("hello").lpad(10, 
fromString("?????")));
    +    assertEquals(fromString("???????"), fromString("").lpad(7, 
fromString("?????")));
    +
    +    assertEquals(fromString("hel"), fromString("hello").rpad(3, 
fromString("????")));
    +    assertEquals(fromString("hello"), fromString("hello").rpad(5, 
fromString("????")));
    +    assertEquals(fromString("hello?"), fromString("hello").rpad(6, 
fromString("????")));
    +    assertEquals(fromString("hello???????"), fromString("hello").rpad(12, 
fromString("????")));
    +    assertEquals(fromString("hello?????"), fromString("hello").rpad(10, 
fromString("?????")));
    +    assertEquals(fromString("???????"), fromString("").rpad(7, 
fromString("?????")));
    +
    +
    +    assertEquals(fromString("数据砖"), fromString("数据ç 
–头").lpad(3, fromString("????")));
    +    assertEquals(fromString("?数据砖头"), fromString("数据ç 
–头").lpad(5, fromString("????")));
    +    assertEquals(fromString("??数据砖头"), fromString("数据ç 
–头").lpad(6, fromString("????")));
    +    assertEquals(fromString("孙行数据砖头"), fromString("数据ç 
–头").lpad(6, fromString("孙行者")));
    +    assertEquals(fromString("孙行者数据砖头"), fromString("数据ç 
–头").lpad(7, fromString("孙行者")));
    +    assertEquals(fromString("孙行者孙行者孙行数据砖头"), 
fromString("数据砖头").lpad(12, fromString("孙行者")));
    --- End diff --
    
    It's fine to match with Hive, never mind.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to