Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r34228513
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -54,3 +60,313 @@ case class CurrentTimestamp() extends LeafExpression {
System.currentTimeMillis() * 1000L
}
}
+
+/**
+ * Abstract class for create time format expressions.
+ */
+abstract class TimeFormatExpression extends UnaryExpression with
ExpectsInputTypes {
+ self: Product =>
+
+ protected val factorToMilli: Int
+
+ protected val cntPerInterval: Int
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType)
+
+ override def dataType: DataType = IntegerType
+
+ override protected def nullSafeEval(timestamp: Any): Any = {
+ val time = timestamp.asInstanceOf[Long] / 1000
+ val longTime: Long = time + TimeZone.getDefault.getOffset(time)
+ ((longTime / factorToMilli) % cntPerInterval).toInt
+ }
+
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
+ val tz = classOf[TimeZone].getName
+ defineCodeGen(ctx, ev, (c) =>
+ s"""(${ctx.javaType(dataType)})
+ ((($c / 1000) + $tz.getDefault().getOffset($c / 1000))
+ / $factorToMilli % $cntPerInterval)"""
+ )
+ }
+}
+
+case class Hour(child: Expression) extends TimeFormatExpression {
+
+ override protected val factorToMilli: Int = 1000 * 3600
+
+ override protected val cntPerInterval: Int = 24
+}
+
+case class Minute(child: Expression) extends TimeFormatExpression {
+
+ override protected val factorToMilli: Int = 1000 * 60
+
+ override protected val cntPerInterval: Int = 60
+}
+
+case class Second(child: Expression) extends TimeFormatExpression {
+
+ override protected val factorToMilli: Int = 1000
+
+ override protected val cntPerInterval: Int = 60
+}
+
+abstract class DateFormatExpression extends UnaryExpression with
ExpectsInputTypes {
+ self: Product =>
+
+ override def dataType: DataType = IntegerType
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(TimestampType)
+
+ protected def isLeapYear(year: Int): Boolean = {
+ year % 4 == 0 && (year % 100 != 0 || year % 400 == 0)
+ }
+
+ def eval(input: InternalRow, f: (Int, Int, Long) => Int): Any = {
+ val valueLeft = child.eval(input)
+ if (valueLeft == null) {
+ null
+ } else {
+ val longTime: Long = valueLeft.asInstanceOf[Long] / 1000
+ val days = longTime / 1000.0 / 3600.0 / 24.0
--- End diff --
fyi double is necessary in order to avoid to big rounding errors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
