Github user tarekauel commented on the pull request:

    https://github.com/apache/spark/pull/6981#issuecomment-119863236
  
    @davies I have implemented the fast path you suggested. In order to try to 
somehow guarantee the correctness of the calculations, I added comprehensive 
tests methods. Maybe you could start reviewing it, if you have time.
    
    @rxin thanks for the hive link. I implemented now the approach that Davies 
suggested. I tested the calculation of the Month for the period 1678 until 1688 
and the tests were all green.
    
    Do we need a check for pre-gregorian calendar?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to