Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7291#discussion_r34256802
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
    @@ -363,6 +364,70 @@ trait Row extends Serializable {
         false
       }
     
    +  protected def canEqual(other: Any) =
    +    other.isInstanceOf[Row] && !other.isInstanceOf[InternalRow]
    --- End diff --
    
    Previously we implemented equals in both internal row(`InternalRow`) and 
external row(`GenericRow`) with very similar logic, so I moved it to the root 
class `Row`, but using `canEqual` to prevent compare internal row and external 
row. (`InternalRow` override `canEqual`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to