Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7291#discussion_r34318500
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -239,16 +239,11 @@ public void setFloat(int ordinal, float value) {
PlatformDependent.UNSAFE.putFloat(baseObject, getFieldOffset(ordinal),
value);
}
- @Override
- public int size() {
- return numFields;
- }
-
/**
* Returns the object for column `i`, which should not be primitive type.
*/
@Override
- public Object get(int i) {
+ public Object apply(int i) {
--- End diff --
Actually I tried it before, but a lot of code need to be updated... I can
do it in a separate PR.
btw, should we just remove `apply` and `size`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
