Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/7253#issuecomment-120227192
imo that would not be correct @vanzin for the case when a1 is completed,
and a2 is incomplete if a1 start times before a2, doing descending start time
check would imply condition returning a2 before a1, and thus showing
incompleted attempt before completed.not right as per intention of the issue.we
always want to show completed first.hence i do not think descending start time
can cover all cases.
please let me know your collective thoughts @vanzin @srowen @squito
@andrewor14 @tgravescs as well on the commit.
For example what you say - "As I said in my first comment, descending start
time should cover all cases."
```
private def compareAttemptInfo(
a1: FsApplicationAttemptInfo,
a2: FsApplicationAttemptInfo): Boolean = {
a1.startTime >= a2.startTime
}
```
For clear illustration, that would lead to 3rd block on all states of a1
and a2.(After block is what is my commit presently)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
