Github user zapletal-martin commented on the pull request:
https://github.com/apache/spark/pull/7337#issuecomment-120394394
@feynmanliang yes there is a lot of duplicated code. I attempted to
refactor that slightly under https://github.com/apache/spark/pull/6996.
It is an interesting idea to just call CrossValidator instead of
implementing the logic. I will have a look into that. But I assume we still
need the Params and Model specific for TrainValidationSplit? We also need to
decide if we want to do that as part of this review or separately.
cc @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
