Github user zapletal-martin commented on the pull request:
https://github.com/apache/spark/pull/7337#issuecomment-120485015
Thanks @feynmanliang. As I mentioned I tried to address the code
duplication in my previous PR differently than you propose, but we decided to
go with the simplest option for now.
I agree what you are proposing makes sense. The only thing that worries me
would be unclear purpose of trainRatio when numFolds != 1. In that case
CrossValidator splits the dataset to numFolds subsets of the same size and the
ratio of training and validation sets is given (e.g. with numFolds set to 4 the
training set is 0.75 and validation is 0.25) and therefore the trainRatio param
would not be used?
We could do that, document that approach and essentially get rid of
TrainValidatorSplit or the other option would be to preserve
TrainValidatorSplit as a wrapper around the functionality to avoid confusion of
CrossValidator having the trainRatio param.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
