Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7348#discussion_r34408953
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -103,63 +91,66 @@ private[sql] object BinaryArithmetic {
def unapply(e: BinaryArithmetic): Option[(Expression, Expression)] =
Some((e.left, e.right))
}
-case class Add(left: Expression, right: Expression) extends
BinaryArithmetic {
+case class Add(left: Expression, right: Expression)
+ extends BinaryArithmetic with ExpectsInputTypes {
+
override def symbol: String = "+"
override def decimalMethod: String = "$plus"
+ override def inputTypes: Seq[AbstractDataType] = Seq(NumericType,
NumericType)
--- End diff --
Logically we only need to give one expect type as `BinaryOperator`s have 2
same types. We can improve this in follow-up PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
