Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7348#discussion_r34408989
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitwise.scala
---
@@ -28,11 +26,13 @@ import org.apache.spark.sql.types._
*
* Code generation inherited from BinaryArithmetic.
*/
-case class BitwiseAnd(left: Expression, right: Expression) extends
BinaryArithmetic {
+case class BitwiseAnd(left: Expression, right: Expression)
+ extends BinaryArithmetic with ExpectsInputTypes {
+
override def symbol: String = "&"
- protected def checkTypesInternal(t: DataType) =
- TypeUtils.checkForBitwiseExpr(t, "operator " + symbol)
+ override def inputTypes: Seq[AbstractDataType] =
+ Seq(TypeCollection(IntegerType, LongType), TypeCollection(IntegerType,
LongType))
--- End diff --
do we allow all kind of integral types or only int and long? If input type
is byte, the result is also byte, but with your change, we will cast byte to
int and result will be int too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
