Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7250#discussion_r34420009
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala 
---
    @@ -297,6 +303,26 @@ class StreamingContextSuite extends SparkFunSuite with 
BeforeAndAfter with Timeo
         Thread.sleep(100)
       }
     
    +  test("registering and de-registering of streamingSource") {
    +    val conf = new SparkConf().setMaster(master).setAppName(appName)
    +    ssc = new StreamingContext(conf, batchDuration)
    +    addInputStream(ssc).register()
    +    ssc.start()
    +
    +    assert(ssc.getState() === StreamingContextState.INITIALIZED)
    +    val sources: ArrayBuffer[Source] = 
StreamingContextSuite.getSources(ssc.env.metricsSystem)
    --- End diff --
    
    I don't think it's necessary to explicitly write the type here. It would be 
simpler not to.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to