Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7250#discussion_r34420008
  
    --- Diff: 
streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala 
---
    @@ -21,17 +21,23 @@ import java.io.{File, NotSerializableException}
     import java.util.concurrent.atomic.AtomicInteger
     
     import org.apache.commons.io.FileUtils
    +import org.apache.spark.metrics.MetricsSystem
    +import org.apache.spark.metrics.source.Source
     import org.scalatest.concurrent.Eventually._
     import org.scalatest.concurrent.Timeouts
     import org.scalatest.exceptions.TestFailedDueToTimeoutException
     import org.scalatest.time.SpanSugar._
    -import org.scalatest.{Assertions, BeforeAndAfter}
    +import org.scalatest.{PrivateMethodTester, Assertions, BeforeAndAfter}
     
     import org.apache.spark.storage.StorageLevel
     import org.apache.spark.streaming.dstream.DStream
     import org.apache.spark.streaming.receiver.Receiver
     import org.apache.spark.util.Utils
    -import org.apache.spark.{Logging, SparkConf, SparkContext, SparkException, 
SparkFunSuite}
    +
    +import org.apache.spark._
    --- End diff --
    
    I wouldn't make this a _ import. Leave it as it was. ALso I think the 
collection imports become unnecessary; see below


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to