Github user jendap commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7375#discussion_r34493745
  
    --- Diff: pom.xml ---
    @@ -1423,34 +1452,12 @@
                 </goals>
                 <configuration>
                   <includeScope>test</includeScope>
    -              <outputFile>${test_classpath_file}</outputFile>
    +         <outputProperty>test_classpath</outputProperty>
                 </configuration>
               </execution>
             </executions>
           </plugin>
     
    -      <!-- This plugin reads a file into maven property. And it lets us 
write groovy !! -->
    --- End diff --
    
    The result is needed. The groovy plugin not. The trick is 6 lines above in 
this commit - maven-dependency-plugin can save to file . The outputFile is 
changed to outputProperty. It does exactly the same thing as the gradle script.
    
    I have double checked it. It does the same thing. The same file is there 
with the same content.
    
    The advantage of this is therefore smaller maven file and faster build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to