Github user jendap commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34496993
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -63,6 +63,7 @@
// The test suite itself is Serializable so that anonymous Function
implementations can be
// serialized, as an alternative to converting these anonymous classes to
static inner classes;
// see http://stackoverflow.com/questions/758570/.
+@SuppressWarnings("serial")
--- End diff --
Actually, I put this there to have absolutely zero warnings across the
whole project in scala-ide. We should, ihmo, not change the compiler settings
because spark uses java serialization by default. Not warning on missing
serialization in new classes would broke spark.
But these two classes are tests anyway.
Should we keep it in the PR or remove it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
