Github user jendap commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7375#discussion_r34500353
  
    --- Diff: sql/hive/pom.xml ---
    @@ -133,7 +133,6 @@
                     </goals>
                     <configuration>
                       <sources>
    -                    <source>src/test/scala</source>
    --- End diff --
    
    It is not needed anymore. It did hurt you in the past because the 
add-sources was done by build-helper-maven-plugin only. Overriding the 
configuration here has overriden the setting from parent. That is why one had 
to repeat it all the time or the dir set in parent was lost.
    
    Now however the addition happens because there are two plugins "adding 
sources".
    
    BTW: We can keep it there. It does not hurt. It is just a cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to