Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/7375#discussion_r34537727
--- Diff: pom.xml ---
@@ -1423,34 +1452,12 @@
</goals>
<configuration>
<includeScope>test</includeScope>
- <outputFile>${test_classpath_file}</outputFile>
+ <outputProperty>test_classpath</outputProperty>
</configuration>
</execution>
</executions>
</plugin>
- <!-- This plugin reads a file into maven property. And it lets us
write groovy !! -->
--- End diff --
I was not aware of this back then, did it even exist in the 2.9 version of
maven dependency plugin ? Anyway the proof that this change is legit is that -
it passes the maven test build especially the distributed ones in core(and
there are lots of them).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
