Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7401#issuecomment-121377354
I left a pass of comments. I think it would be good to try to move more of
the code into Python and to only shell out to external scripts when running PR
checks, unit tests, or when performing Git commands. Things like globbing
files or sending HTTP requests should be done using Python standard libraries.
I think there are also a number of small bugs that will prevent this from
running correctly as-is. I found a number of these by running the `prospector`
linter on this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
