Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7401#discussion_r34702586
--- Diff: dev/run-tests-jenkins.py ---
@@ -0,0 +1,256 @@
+#!/usr/bin/env python2
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from __future__ import print_function
+import os
+import sys
+import json
+import urllib2
+import functools
+import subprocess
+
+from sparktestsupport import SPARK_HOME, ERROR_CODES
+from sparktestsupport.shellutils import run_cmd, rm_r
+
+
+def print_err(msg):
+ """
+ Given a set of arguments, will print them to the STDERR stream
+ """
+ print(msg, file=sys.stderr)
+
+
+def post_message_to_github(msg, ghprb_pull_id):
+ print("Attempting to post to Github...")
+
+ posted_message = json.dumps({"body": msg})
+ request =
urllib2.Request("https://api.github.com/repos/apache/spark/issues/"; +
+ ghprb_pull_id + "/comments",
+ headers={
+ "Authorization": "x-oauth-basic:" +
os.environ['GITHUB_OATH_KEY'],
+ "Content-Type": "application/json"
+ },
+ data=posted_message)
+ try:
+ response = urllib2.urlopen(request)
+ except urllib2.URLError as url_e:
+ print_err("Failed to post message to GitHub.")
+ print_err(" > urllib2_status: %s" % url_e.reason[1])
+ print_err(" > data: %s" % posted_message)
+ except urllib2.HTTPError as http_e:
+ print_err("Failed to post message to GitHub.")
+ print_err(" > http_code: %s" % http_e.code)
+ print_err(" > api_response: %s" % http_e.read())
+ print_err(" > data: %s" % posted_message)
+
+ if response.getcode() == 201:
+ print(" > Post successful.")
+
+
+def send_archived_logs():
+ print("Archiving unit tests logs...")
+
+ # find any files rescursively with the name 'unit-tests.log'
+ log_files = [os.path.join(path, f)
+ for path, _, filenames in os.walk(SPARK_HOME)
+ for f in filesnames if f == 'unit-tests.log']
+ # ensure we have a default list if no 'unit-tests.log' files were found
+ log_files = log_files if log_files else list()
+
+ # check if any of the three explicit paths exist on the system
+ log_files += [f for f in
['./sql/hive/target/HiveCompatibilitySuite.failed',
+
'./sql/hive/target/HiveCompatibilitySuite.hiveFailed',
+
'./sql/hive/target/HiveCompatibilitySuite.wrong']
+ if os.path.isfile(f)]
+
+ if log_files:
+ log_archive = "unit-tests-logs.tar.gz"
+
+ run_cmd(['tar', 'czf', log_archive] +
log_files.strip().split('\n'))
+
+ jenkins_build_dir = os.environ["JENKINS_HOME"] + "/jobs/" +
os.environ["JOB_NAME"] + \
+ "/builds/" + os.environ["BUILD_NUMBER"]
+
+ scp_proc = subprocess.Popen(['scp', log_archive,
+ 'amp-jenkins-master:' +
jenkins_build_dir + '/' + log_archive],
+ stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE)
+ scp_stdout, scp_stderr = scp_proc.communicate()
+ scp_returncode = scp_proc.returncode
+
+ if not scp_returncode == 0:
+ print_err("Failed to send archived unit tests logs to Jenkins
master.")
+ print_err(" > scp_status: %s" % scp_returncode)
+ print_err(" > scp_output: %s" % scp_stdout)
+ else:
+ print(" > Send successful.")
+ else:
+ print_err(" > No log files found.")
+
+ rm_r(log_archive)
+
+
+def run_pr_checks(pr_tests, ghprb_actual_commit, sha1):
+ """
+ Executes a set of pull request checks to ease development and report
issues with various
+ components such as style, linting, dependencies, compatibilities, etc.
+ @return a list of messages to post back to Github
+ """
+ # Ensure we save off the current HEAD to revert to
+ current_pr_head = run_cmd(['git', 'rev-parse', 'HEAD'],
return_output=True).strip()
+ pr_results = list()
+
+ for pr_test in pr_tests:
+ pr_results.append(run_cmd(['bash', os.path.join(SPARK_HOME, 'dev',
'tests', pr_test),
+ ghprb_actual_commit, sha1],
+ return_output=True).strip())
+ # Ensure, after each test, that we're back on the current PR
+ run_cmd(['git', 'checkout', '-f', current_pr_head])
+ return pr_results
+
+
+def pr_message(build_display_name,
+ build_url,
+ ghprb_pull_id,
+ short_commit_hash,
+ commit_url,
+ msg,
+ post_msg=''):
+ # align the arguments properly for string formatting
+ str_args = (build_display_name,
+ msg,
+ build_url,
+ ghprb_pull_id,
+ short_commit_hash,
+ commit_url,
+ str(' ' + post_msg + '.') if post_msg else '.')
+ return '**[Test build %s %s](%sconsole)** for PR %s at commit
[\`%s\`](%s)%s' % str_args
+
+
+def run_tests(tests_timeout):
+ """
+ Runs the `dev/run-tests` script and responds with the correct error
message
+ under the various failure scenarios.
+ @return a tuple containing the test result code and the result note to
post to Github
+ """
+
+ test_proc = subprocess.Popen(['timeout',
+ tests_timeout,
+ os.path.join(SPARK_HOME, 'dev',
'run-tests')]).wait()
+ test_result_code = test_proc.returncode
+
+ def failure_result_note(msg):
+ ' * This patch **fails ' + msg + '**.'
+
+ failure_note_by_errcode = {
+ ERROR_CODES["BLOCK_GENERAL"]: failure_result_note('some tests'),
+ ERROR_CODES["BLOCK_RAT"]: failure_result_note('RAT tests'),
+ ERROR_CODES["BLOCK_SCALA_STYLE"]: failure_result_note('Scala style
tests'),
+ ERROR_CODES["BLOCK_PYTHON_STYLE"]: failure_result_note('Python
style tests'),
+ ERROR_CODES["BLOCK_DOCUMENTATION"]: failure_result_note('to
generate documentation'),
+ ERROR_CODES["BLOCK_BUILD"]: failure_result_note('to build'),
+ ERROR_CODES["BLOCK_MIMA"]: failure_result_note('MiMa tests'),
+ ERROR_CODES["BLOCK_SPARK_UNIT_TESTS"]: failure_result_note('Spark
unit tests'),
+ ERROR_CODES["BLOCK_PYSPARK_UNIT_TESTS"]:
failure_result_note('PySpark unit tests'),
+ ERROR_CODES["BLOCK_SPARKR_UNIT_TESTS"]:
failure_result_note('SparkR unit tests'),
+ ERROR_CODES["BLOCK_TIMEOUT"]: failure_result_note('from timeout
after a configured wait' +
+ ' of \`' +
tests_timeout + '\`')
+ }
+
+ if test_result == 0:
+ test_result_note = ' * This patch passes all tests.'
+ else:
+ test_result_note = failure_note_by_errcode[test_result]
+ send_archived_logs()
+
+ return [test_result_code, test_result_note]
+
+
+def main():
+ # Important Environment Variables
+ # ---
+ # $ghprbActualCommit
+ # This is the hash of the most recent commit in the PR.
+ # The merge-base of this and master is the commit from which the PR
was branched.
+ # $sha1
+ # If the patch merges cleanly, this is a reference to the merge
commit hash
+ # (e.g. "origin/pr/2606/merge").
+ # If the patch does not merge cleanly, it is equal to
$ghprbActualCommit.
+ # The merge-base of this and master in the case of a clean merge is
the most recent commit
+ # against master.
+ ghprb_pull_id = os.environ["ghprbPullId"]
+ ghprb_actual_commit = os.environ["ghprbActualCommit"]
+ sha1 = os.environ["sha1"]
+
+ # Marks this build as a pull request build.
+ os.environ["AMP_JENKINS_PRB"] = "true"
+ build_display_name = os.environ["BUILD_DISPLAY_NAME"]
+ build_url = os.environ["BUILD_URL"]
+
+ commit_url = "https://github.com/apache/spark/commit/"; +
ghprb_actual_commit
+
+ # GitHub doesn't auto-link short hashes when submitted via the API,
unfortunately. :(
+ short_commit_hash = ghprb_actual_commit[0:7]
+
+ # format: http://linux.die.net/man/1/timeout
+ # must be less than the timeout configured on Jenkins (currently 180m)
+ tests_timeout = "175m"
+
+ # Array to capture all test names to run on the pull request. These
tests are represented
+ # by their file equivalents in the dev/tests/ directory.
+ #
+ # To write a PR test:
+ # * the file must reside within the dev/tests directory
+ # * be an executable bash script
+ # * accept three arguments on the command line, the first being the
Github PR long commit
+ # hash, the second the Github SHA1 hash, and the final the current
PR hash
+ # * and, lastly, return string output to be included in the pr
message output that will
+ # be posted to Github
+ pr_tests = ["pr_merge_ability",
--- End diff --
Do you mind making the wrapping change here, so that this is written as
```python
pr_tests = [
"pr_merge_ability",
"pr_public_classes",
# DISABLED (pwendell) "pr_new_dependencies",
]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
