Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7390#discussion_r34630251
--- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/Interval.java
---
@@ -43,12 +43,13 @@
* Finally is the unit name, ends with an optional "s".
*/
private static String unitRegex(String unit) {
- return "(?:\\s+(-?\\d+)\\s+" + unit + "s?)?";
+ return "(?:\\s+(-?\\d+)\\s+" + unit + "s?\\s*)?";
--- End diff --
@cloud-fan maybe I'm blind but how does this use Unsafe? I don't see how it
benefits.
`java.time.Duration` is an `int` + `long` too. Is this really needed? at
least, why in unsafe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
