Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7408#discussion_r34639995
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
    @@ -158,7 +158,7 @@ case class Exchange(
             val rdd = if (needToCopyObjectsBeforeShuffle(part, serializer)) {
               child.execute().mapPartitions { iter =>
                 val hashExpressions = newMutableProjection(expressions, 
child.output)()
    -            iter.map(r => (hashExpressions(r).copy(), r.copy()))
    +            iter.map(r => (hashExpressions(r).copy, r.copy()))
    --- End diff --
    
    hm since copy is a verb, it is better to keep the () i think. also we 
defined copy with ()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to