Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7268#discussion_r34714277
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -366,16 +377,19 @@ object ShuffleBlockFetcherIterator {
*/
private[storage] sealed trait FetchResult {
val blockId: BlockId
+ val address: BlockManagerId
}
/**
* Result of a fetch from a remote block successfully.
* @param blockId block id
+ * @param address BlockManager that the block was fetched from.
* @param size estimated size of the block, used to calculate
bytesInFlight.
* Note that this is NOT the exact bytes.
* @param buf [[ManagedBuffer]] for the content.
*/
- private[storage] case class SuccessFetchResult(blockId: BlockId, size:
Long, buf: ManagedBuffer)
+ private[storage] case class SuccessFetchResult(
+ blockId: BlockId, address: BlockManagerId, size: Long, buf:
ManagedBuffer)
--- End diff --
Minor style nit, but I think that these parameters should be listed one per
line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
