Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7268#discussion_r34714285
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -384,8 +398,9 @@ object ShuffleBlockFetcherIterator {
/**
* Result of a fetch from a remote block unsuccessfully.
* @param blockId block id
+ * @param address BlockManager that the block was attempted to be
fetched from
* @param e the failure exception
*/
- private[storage] case class FailureFetchResult(blockId: BlockId, e:
Throwable)
- extends FetchResult
+ private[storage] case class FailureFetchResult(
+ blockId: BlockId, address: BlockManagerId, e: Throwable) extends
FetchResult
--- End diff --
Same one parameter per line style nit here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
