Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7434#discussion_r34759923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -20,17 +20,21 @@ package org.apache.spark.sql.catalyst.expressions
import com.clearspring.analytics.stream.cardinality.HyperLogLog
import org.apache.spark.sql.catalyst.InternalRow
-import org.apache.spark.sql.catalyst.trees
import org.apache.spark.sql.catalyst.errors.TreeNodeException
import org.apache.spark.sql.catalyst.analysis.TypeCheckResult
import org.apache.spark.sql.catalyst.util.TypeUtils
import org.apache.spark.sql.types._
import org.apache.spark.util.collection.OpenHashSet
-abstract class AggregateExpression extends Expression {
+trait AggregateExpression extends Expression {
--- End diff --
it'd result in a lot more code changes to get it working. e.g.
```scala
abstract class AggregateFunction
extends LeafExpression with AggregateExpression with Serializable {
self: Product =>
/** Base should return the generic aggregate expression that this
function is computing */
val base: AggregateExpression
override def nullable: Boolean = base.nullable <--- this won't work
anymore
override def dataType: DataType = base.dataType
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
