Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/7434#discussion_r34793734
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -40,13 +40,14 @@ import org.apache.spark.sql.types._
* requested. The attributes produced by this function will be
automatically copied anytime rules
* result in changes to the Generator or its children.
*/
-abstract class Generator extends Expression {
- self: Product =>
+trait Generator extends Expression { self: Product =>
--- End diff --
Nothing. Unless you have circular dependencies between traits, which I
doubt. I avoid self-types as much as I can. Inheritance is much easier to
understand and covers 99% of cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
