Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4055#issuecomment-122009867
@kayousterhout @markhamstra do you have any opinions on the proposed
solutions here? To recap I think the choices are:
1) change `stage.pendingTasks: Set[Task]` to `stage.pendingPartitions:
Set[Int]`
2) change the condition for registering map output to
```scala
if (runningStages.contains(shuffleStage) &&
(shuffleStage.pendingTasks.isEmpty || shuffleStage.isAvailable)) {
```
3) change the condition for registering map output to
```scala
if (runningStages.contains(shuffleStage) && shuffleStage.isAvailable)
```
and adding a separate branch for
```scala
if (runningStages.contains(shuffleStage) &&
shuffleStage.pendingTasks.isEmpty)
```
which would just call `markStageAsFinished`
4) add `hashCode` and `equals` to `Task`, which would only look at stage &
partition. (as currently implemented in this PR.
all options pass tests. My slight preference is (2)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
