Github user josepablocam commented on a diff in the pull request:
https://github.com/apache/spark/pull/7430#discussion_r34833968
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -1093,6 +1093,27 @@ private[python] class PythonMLLibAPI extends
Serializable {
LinearDataGenerator.generateLinearRDD(
sc, nexamples, nfeatures, eps, nparts, intercept)
}
+
+ /**
+ * Wrapper around Statistics.kolmogorovSmirnovTestWrapper with default
params.
+ */
+ def kolmogorovSmirnovTestWrapper(
+ data: JavaRDD[Double],
+ distName: String): KolmogorovSmirnovTestResult = {
+ Statistics.kolmogorovSmirnovTest(data, distName)
+ }
+
+ /**
+ * Wrapper around Statistics.kolmogorovSmirnovTestWrapper.
+ */
+ def kolmogorovSmirnovTestWrapper(
+ data: JavaRDD[Double],
+ distName: String,
+ params: JList[Double]): KolmogorovSmirnovTestResult = {
+ val seqParams = params.asScala.toSeq
+ Statistics.kolmogorovSmirnovTest(data, distName, seqParams: _*)
+ }
+
--- End diff --
I'll defer to @mengxr and @sryza but just wondering: do we need the 2
separate wrappers? seems to me that 1 should do (the last one). If params is
passed in empty on the python side, that should just be an empty list, and the
asScala.toSeq, will make it an empty sequence.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
