Github user MechCoder commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7430#discussion_r34861716
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
    @@ -1093,6 +1093,27 @@ private[python] class PythonMLLibAPI extends 
Serializable {
         LinearDataGenerator.generateLinearRDD(
           sc, nexamples, nfeatures, eps, nparts, intercept)
       }
    +
    +  /**
    +   * Wrapper around Statistics.kolmogorovSmirnovTestWrapper with default 
params.
    +   */
    +  def kolmogorovSmirnovTestWrapper(
    +      data: JavaRDD[Double],
    +      distName: String): KolmogorovSmirnovTestResult = {
    +    Statistics.kolmogorovSmirnovTest(data, distName)
    +  }
    +
    +  /**
    +   * Wrapper around Statistics.kolmogorovSmirnovTestWrapper.
    +   */
    +  def kolmogorovSmirnovTestWrapper(
    +      data: JavaRDD[Double],
    +      distName: String,
    +      params: JList[Double]): KolmogorovSmirnovTestResult = {
    +    val seqParams = params.asScala.toSeq
    +    Statistics.kolmogorovSmirnovTest(data, distName, seqParams: _*)
    +  }
    +
    --- End diff --
    
    It seems like it. I'll make the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to