Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7274#discussion_r34855500
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -544,58 +544,82 @@ private[master] class Master(
        * has enough cores and memory. Otherwise, each executor grabs all the 
cores available on the
        * worker by default, in which case only one executor may be launched on 
each worker.
    --- End diff --
    
    can you add to this java doc what the new return type is? Also, it would be 
good to add a short paragraph to explain the necessity to allocate N cores at a 
time, and give an example of where allocating 1 core at a time fails.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to