Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7274#issuecomment-122145820
Hey @nishkamravi2 thanks so much for fixing this. The old behavior is
clearly incorrect. I agree with most of your changes and I would definitely
like to see this merged.
One thing is that it would be great if you could also write some tests for
the `scheduleExecutorsOnWorker` method. I wasn't sure if you planned to add
that since you kept it `private[master]`. If we have sufficient tests for the
scheduling code here then I would feel confident to back port this into 1.4.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
