Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/7440#discussion_r34862787
--- Diff: R/pkg/R/schema.R ---
@@ -69,10 +69,11 @@ structType.structField <- function(x, ...) {
#' @param ... further arguments passed to or from other methods
print.structType <- function(x, ...) {
cat("StructType\n",
- sapply(x$fields(), function(field) { paste("|-", "name = \"",
field$name(),
- "\", type = \"",
field$dataType.toString(),
- "\", nullable = ",
field$nullable(), "\n",
- sep = "") })
+ sapply(x$fields(), function(field) {
+ paste("|-", "name = \"", field$name(),
+ "\", type = \"", field$dataType.toString(),
+ "\", nullable = ", field$nullable(), "\n",
+ sep = "") })
--- End diff --
It's not about style for comments but how about like as follows?
```
sapply(x$fields(),
function(field) {
paste("|-", "name = \"", field$name(),
"\", type = \"", field$dataType.toString(),
"\", nullable = ", field$nullable(), "\n",
sep = "")
})
```
@shivaram Do you have any suggestion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
