Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7440#discussion_r34949602
--- Diff: R/pkg/R/utils.R ---
@@ -440,19 +446,23 @@ processClosure <- function(node, oldEnv, defVars,
checkedFuncs, newEnv) {
# Namespaces other than "SparkR" will not be searched.
if (!isNamespace(func.env) ||
(getNamespaceName(func.env) == "SparkR" &&
- !(nodeChar %in% getNamespaceExports("SparkR")))) { # Only
include SparkR internals.
+ !(nodeChar %in% getNamespaceExports("SparkR")))) {
--- End diff --
Hmm yes - the `(` in `getNameSpace` could be aligned with the previous line
I guess. However when we have nested conditions I actually think its more
readable to align the inner condition like a new statement (with 2 spaces) as
it is done here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
