Github user rtreffer commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7455#discussion_r34868189
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetIOSuite.scala ---
    @@ -107,7 +107,7 @@ class ParquetIOSuiteBase extends QueryTest with 
ParquetTest {
             // Parquet doesn't allow column names with spaces, have to add an 
alias here
             .select($"_1" cast decimal as "dec")
     
    -    for ((precision, scale) <- Seq((5, 2), (1, 0), (1, 1), (18, 10), (18, 
17))) {
    +    for ((precision, scale) <- Seq((5, 2), (1, 0), (1, 1), (18, 10), (18, 
17), (19, 0), (38, 37))) {
    --- End diff --
    
    This should fail if due to followParquetFormatSpec = false.
    
    I was trying to test "withSQLConf" but couldn't get it to work: 
https://github.com/apache/spark/pull/6796/files#diff-82fab6131b7092c5faa4064fd04c3d72R135
    
    (I have to find out why I can't run tests locally, ./build/sbt sql/test 
fails with a compiler assertion?!?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to