Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7455#discussion_r34870593
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetIOSuite.scala ---
    @@ -107,7 +107,7 @@ class ParquetIOSuiteBase extends QueryTest with 
ParquetTest {
             // Parquet doesn't allow column names with spaces, have to add an 
alias here
             .select($"_1" cast decimal as "dec")
     
    -    for ((precision, scale) <- Seq((5, 2), (1, 0), (1, 1), (18, 10), (18, 
17))) {
    +    for ((precision, scale) <- Seq((5, 2), (1, 0), (1, 1), (18, 10), (18, 
17), (19, 0), (38, 37))) {
    --- End diff --
    
    Note that as stated in the PR description, this PR doesn't support writing 
decimals when `followParquetFormatSpec` is true, because it doesn't make sense 
yet until the whole Parquet write path is refactored to conform Parquet format 
spec.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to