Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7194#issuecomment-122557663
@yijieshen, that's a good question. I think that there may be some
situations where we do equality comparisons without using types' orderings or
comparators to perform those comparisons, so I don't think know whether this
patch entirely addresses SPARK-9145.
To fix SPARK-9145, I think we'll have to update `CodeGenerator.genEqual()`
and its non-code-generated equivalent. We may also need to perform
normalization of NaN values when writing them into UnsafeRow format in order to
ensure that fast equality checks based on UnsafeRows' bytes will work correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
