Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7194#discussion_r34950704
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeExternalSortSuite.scala
---
@@ -97,7 +93,8 @@ class UnsafeExternalSortSuite extends SparkPlanTest with
BeforeAndAfterAll {
inputDf,
UnsafeExternalSort(sortOrder, global = true, _: SparkPlan,
testSpillFrequency = 23),
Sort(sortOrder, global = true, _: SparkPlan),
- sortAnswers = false
+ sortAnswers = false,
+ compareStrings = true
--- End diff --
Instead of comparing as String, could you update the Row.equals() to handle
NaN (we need to do this eventually)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
