Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7194#discussion_r34953911
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala
---
@@ -126,6 +126,19 @@ class PredicateSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(IsNaN(Literal(5.5f)), false)
}
+ test("NaN equality and comparison") {
+ def testNaN(nan: Expression): Unit = {
+ checkEvaluation(nan === nan, true)
+ checkEvaluation(nan <=> nan, true)
+// checkEvaluation(nan <= nan, true)
--- End diff --
Interestingly, this test case fails even though I updated GeneratedOrdering
and the interpreted orderings to support our defined NaN semantics. This
implies that we may be using the wrong ordering in the implementation of these
expressions.
If it turns out that those expressions are mis-handling orderings in a more
general way, then I'll open a separate PR to fix that (I suspect that we'll see
similar failures when trying to order byte arrays).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
