Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7194#discussion_r34954026
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala
---
@@ -126,6 +126,19 @@ class PredicateSuite extends SparkFunSuite with
ExpressionEvalHelper {
checkEvaluation(IsNaN(Literal(5.5f)), false)
}
+ test("NaN equality and comparison") {
+ def testNaN(nan: Expression): Unit = {
+ checkEvaluation(nan === nan, true)
+ checkEvaluation(nan <=> nan, true)
+// checkEvaluation(nan <= nan, true)
--- End diff --
Ah, I also see now that I should remove this test and add `NaN` literals to
the `equalValues` list above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
