Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7528#issuecomment-122951911
Hi @GraceH thanks for finding this bug and posting the PR. The changes
look completely reasonable, but would it be possible to add a unit test? I
know this is a big ask, since it doesn't look like there are any tests right
now on that test anything like this for `CoarseGrainedSchedulerBackend`, so it
will probably take some work to do.
I believe this changes are correct, so the test isn't so much about
verifying this fix as it is to prevent future regressions. It would also
really help in the future for following along the code -- eg., it took me a
while to figure out how anything was ever removed from
`executorsPendingToRemove`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
