Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7528#issuecomment-123145950
Hi @GraceH this looks great. I left a few minor wording suggestions to
improve readability.
As for unit tests, I do agree that we should have them, but it seems
outside the scope of this fix since properly testing all of this logic would
require a non-trivial refactor. In this case, I am more inclined to merge in
this fix than to delay it indefinitely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
