Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7546#discussion_r35063387
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
 ---
    @@ -353,7 +353,7 @@ class StringExpressionsSuite extends SparkFunSuite with 
ExpressionEvalHelper {
       test("FORMAT") {
    --- End diff --
    
    existing: would you mind rewriting these to avoid the use of row and just 
use literals? using a row makes the test cases harder to follow since you have 
to look in multiple places to understand what is going on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to