Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7546#discussion_r35063602
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
 ---
    @@ -476,7 +476,7 @@ case class StringRPad(str: Expression, len: Expression, 
pad: Expression)
     /**
      * Returns the input formatted according do printf-style format strings
      */
    -case class StringFormat(children: Expression*) extends Expression with 
CodegenFallback {
    +case class StringFormat(children: Expression*) extends Expression {
    --- End diff --
    
    No, I don't think so.  We just zip with `children` to check the types so I 
think it can work either way.  Just remember to subtract 1 when figuring out 
how many AnyDataTypes to fill in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to